Re: [PATCH 0/1] exit: kill signal_struct->quick_threads

[Oleg Nesterov]

Forgot to mention ...

On 06/10, Oleg Nesterov wrote:
>
> I guess I was not clear. Of course, SIGNAL_GROUP_EXIT must be always
> set under ->siglock. But I think synchronize_group_exit() can just
> return if SIGNAL_GROUP_EXIT is already set? If nothing else, this is
> what do_group_exit() does.

Just in case... I guess do_group_exit() needs some cleanups too. For
example,

	if (sig->flags & SIGNAL_GROUP_EXIT)
		exit_code = sig->group_exit_code;

without siglock is racy, exit_code can be wrong (not a big problem).
LOAD(sig->flags) can make KCSAN unhappy. Etc.

But this all has nothing to do with 1/1 ?

Oleg.