Re: [PATCH] dma-buf/heaps: Correct the types of fd_flags and heap_flags

From: Carlos Llamas
Date: Mon Jun 10 2024 - 13:05:31 EST


On Thu, Jun 06, 2024 at 02:02:13PM +1200, Barry Song wrote:
> From: Barry Song <v-songbaohua@xxxxxxxx>
>
> dma_heap_allocation_data defines the UAPI as follows:
>
> struct dma_heap_allocation_data {
> __u64 len;
> __u32 fd;
> __u32 fd_flags;
> __u64 heap_flags;
> };
>
> But dma heaps are casting both fd_flags and heap_flags into
> unsigned long. This patch makes dma heaps - cma heap and
> system heap have consistent types with UAPI.
>
> Signed-off-by: Barry Song <v-songbaohua@xxxxxxxx>
> ---

Looks good to me, thanks!

Reviewed-by: Carlos Llamas <cmllamas@xxxxxxxxxx>