Re: [PATCH] nvdimm: make nd_class constant

From: Dan Williams
Date: Mon Jun 10 2024 - 13:45:15 EST


Greg Kroah-Hartman wrote:
> Now that the driver core allows for struct class to be in read-only
> memory, we should make all 'class' structures declared at build time
> placing them into read-only memory, instead of having to be dynamically
> allocated at runtime.

Change looks good to me,

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>

...changelog grammar tripped me up though, how about:

"Now that the driver core allows for struct class to be in read-only
memory, it is possible to make all 'class' structures be declared at
build time. Move the class to a 'static const' declaration and register
it rather than dynamically create it."