Re: [PATCH 01/14] scsi: fnic: Replace shost_printk with pr_info/pr_err

From: Hannes Reinecke
Date: Tue Jun 11 2024 - 02:32:52 EST


On 6/10/24 23:50, Karan Tilak Kumar wrote:
Sending host information to shost_printk
prior to host initialization in fnic is unnecessary.
Replace shost_printk and a printk prior to this
initialization with pr_info and pr_err accordingly.

Please use 'dev_info' and 'dev_err' instead.
pr_info/pr_err have the problem that they don't reference
the device generating the message, making tracking of
related messages in a large message log problematic.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich