Re: [PATCH 1/3] media: vgxy61: Fix driver name

From: Krzysztof Kozlowski
Date: Tue Jun 11 2024 - 02:47:31 EST


On 10/06/2024 17:08, Benjamin Mugnier wrote:
> From 'st-vgxy61' to 'vgxy61'.
> Align with other drivers to not use the vendor prefix.
> Also the vendor prefix is already mentioned in the device tree
> compatible string, being 'st,vgxy61', and does not need to be expressed twice.

What bindings have anything to do with driver name?

I think I made it clear last time.


>
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx>
> ---
> .../media/i2c/{st,st-vgxy61.yaml => st,vgxy61.yaml} | 6 +++---
> Documentation/userspace-api/media/drivers/index.rst | 2 +-
> .../media/drivers/{st-vgxy61.rst => vgxy61.rst} | 0
> MAINTAINERS | 8 ++++----
> drivers/media/i2c/Kconfig | 2 +-
> drivers/media/i2c/Makefile | 2 +-
> drivers/media/i2c/{st-vgxy61.c => vgxy61.c} | 2 +-
> 7 files changed, 11 insertions(+), 11 deletions(-)
> rename Documentation/devicetree/bindings/media/i2c/{st,st-vgxy61.yaml => st,vgxy61.yaml} (95%)
> rename Documentation/userspace-api/media/drivers/{st-vgxy61.rst => vgxy61.rst} (100%)
> rename drivers/media/i2c/{st-vgxy61.c => vgxy61.c} (99%)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
> similarity index 95%
> rename from Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> rename to Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
> index 8c28848b226a..4e4c2c7ad168 100644
> --- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/st,vgxy61.yaml
> @@ -2,7 +2,7 @@
> # Copyright (c) 2022 STMicroelectronics SA.
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/media/i2c/st,st-vgxy61.yaml#
> +$id: http://devicetree.org/schemas/media/i2c/st,vgxy61.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: STMicroelectronics VGxy61 HDR Global Shutter Sensor Family
> @@ -23,7 +23,7 @@ description: |-
>
> properties:
> compatible:
> - const: st,st-vgxy61
> + const: st,vgxy61

Why? No. NAK.


Best regards,
Krzysztof