Re: [PATCH net V3 0/3] net: lan743x: Fixes for multiple WOL related issues

From: Horatiu Vultur
Date: Tue Jun 11 2024 - 03:11:32 EST


Hi Raju,

Is this not supposed to be v4?
Because I can see v3 here:
https://www.spinics.net/lists/netdev/msg1002225.html

The 06/11/2024 11:57, Raju Lakkaraju wrote:
> This patch series implement the following fixes:
> 1. Disable WOL upon resume in order to restore full data path operation
> 2. Support WOL at both the PHY and MAC appropriately
> 3. Remove interrupt mask clearing from config_init
>
> Patch-3 was sent seperately earlier. Review comments in link:
> https://lore.kernel.org/lkml/4a565d54-f468-4e32-8a2c-102c1203f72c@xxxxxxx/T/
>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@xxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406052200.w3zuc32H-lkp@xxxxxxxxx/

I think you should drop the 'Reported-by' and 'Closes' tags because the
issue that is getting closed is the one that you introduced in one of
your previous version of the patch series.

>
> Raju Lakkaraju (3):
> net: lan743x: disable WOL upon resume to restore full data path
> operation
> net: lan743x: Support WOL at both the PHY and MAC appropriately
> net: phy: mxl-gpy: Remove interrupt mask clearing from config_init
>
> .../net/ethernet/microchip/lan743x_ethtool.c | 44 ++++++++++++--
> drivers/net/ethernet/microchip/lan743x_main.c | 46 ++++++++++++---
> drivers/net/ethernet/microchip/lan743x_main.h | 28 +++++++++
> drivers/net/phy/mxl-gpy.c | 58 ++++++++++++-------
> 4 files changed, 144 insertions(+), 32 deletions(-)
>
> --
> 2.34.1
>
>

--
/Horatiu