Re: [PATCH 2/3] media: vgxy61: Add legacy compatible string

[Sakari Ailus]

Hi Krzysztof,

On Tue, Jun 11, 2024 at 08:47:25AM +0200, Krzysztof Kozlowski wrote:
> On 10/06/2024 17:08, Benjamin Mugnier wrote:
> > As the driver has been renamed from 'st-vgxy61' to 'vgxy61', its
> > compatible string has been updated to reflect this change. Therefore old
> > device trees will not work anymore.
> > Add the old driver name as another compatible name to handle the
> > retro compatibility.
> > 
> > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx>
> > ---
> >  drivers/media/i2c/vgxy61.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
> > index 30378e962016..ca3b43608dad 100644
> > --- a/drivers/media/i2c/vgxy61.c
> > +++ b/drivers/media/i2c/vgxy61.c
> > @@ -1867,6 +1867,11 @@ static void vgxy61_remove(struct i2c_client *client)
> >  }
> >  
> >  static const struct of_device_id vgxy61_dt_ids[] = {
> > +	{ .compatible = "st,vgxy61" },
> > +	/*
> > +	 * Previously the driver was named 'st-vgxy61' instead of simply
> > +	 * 'vgxy61', keep it for retrocompatibility purposes.
> 
> NAK.

Is that because the comment says "driver" rather than "device"?

Please try to express clearer what you'd expect from the patch author.

-- 
Kind regards,

Sakari Ailus