Re: [PATCH v3] cpufreq/cppc: Remove the desired_perf compare when set target

From: Viresh Kumar
Date: Tue Jun 11 2024 - 05:11:03 EST


On 11-06-24, 09:54, Ionela Voinescu wrote:
> It's alright with me.

Great.

> Some "nits":
> - the "desired_perf" local variable could be removed in this case.

Riwen, please fix this and resend.

> - [note] while this change helps, we'd still need policy->cur to always
> have the latest request value (see details at [1]) for this check to
> be made obsolete by the comparison between target_freq and policy->cur,
> as mentioned in the commit message. But this is/can be a separate
> matter.
>
> [1] https://lore.kernel.org/lkml/ZmB1qKucR5fXk100@xxxxxxx/

Yeah, lets discuss that in the other thread only.

--
viresh