Re: [PATCH] KVM: x86/tdp_mmu: Sprinkle __must_check

From: Huang, Kai
Date: Tue Jun 11 2024 - 05:41:29 EST


On Tue, 2024-06-11 at 04:11 -0400, Paolo Bonzini wrote:
> From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
>
> The TDP MMU function __tdp_mmu_set_spte_atomic uses a cmpxchg64 to replace
> the SPTE value and returns -EBUSY on failure. The caller must check the
> return value and retry. Add __must_check to it, as well as to two more
> functions that forward the return value of __tdp_mmu_set_spte_atomic to
> their caller.
>
> Signed-off-by: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
> Reviewed-by: Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx>
> Message-Id: <8f7d5a1b241bf5351eaab828d1a1efe5c17699ca.1705965635.git.isaku.yamahata@xxxxxxxxx>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> ---
>

Acked-by: Kai Huang <kai.huang@xxxxxxxxx>