Re: [PATCH v2 1/2] selftests: Rename sigaltstack to generic signal

From: Mark Brown
Date: Tue Jun 11 2024 - 06:55:09 EST


On Tue, Jun 11, 2024 at 01:26:49PM +0530, Dev Jain wrote:
> Rename sigaltstack to signal, and rename the existing test to
> sigaltstack.c.
>
> Signed-off-by: Dev Jain <dev.jain@xxxxxxx>
> ---

If people review patches and give a tag for them you should carry the
tag forward to avoid having to duplicate the review. From v1:

I think this is reasonable if we're going to add more generic signal
tests - sigaltstack is a fairly small bit of functionality and having it
covered as part of a broader signal suite and the overhead of setting up
the suite separately is probably not worth it.

Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature