Re: [PATCH net-next v4 3/4] net: macb: Add ARP support to WOL

[Andrew Lunn]

> > > +	/* Don't manage WoL on MAC if there's a failure in talking to the PHY */
> > > +	if (!!ret && ret != -EOPNOTSUPP)
> > >   		return ret;
> > 
> > The comment is wrong. You could be happily talking to the PHY, it just
> > does not support what you asked it to do.
> > 
> 
> 
> These are the 3 possible return scenarios
> 
> 1. -EOPNOTSUPP. : When there is no PHY or no set_wol() in PHY driver.
> 2. 0 : Success
> 3. any error (-EINVAL, ... ) from set_wol()
> 
> we are returning in case 3.
> 
> The comment can be "Don't manage WoL on MAC, if PHY set_wol() fails"

O.K.

You don't need the !! on ret.

	Andrew