Re: [PATCH] bitops: Add a comment explaining the double underscore macros

From: Linus Walleij
Date: Tue Jun 11 2024 - 09:08:38 EST


On Tue, Jun 11, 2024 at 2:38 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> Linus Walleij pointed out that a new comer might be confused about the
> difference between set_bit() and __set_bit(). Add a comment explaining
> the difference.
>
> Link: https://lore.kernel.org/all/CACRpkdZFPG_YLici-BmYfk9HZ36f4WavCN3JNotkk8cPgCODCg@xxxxxxxxxxxxxx/
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> v2: re-word the comment, put it right next to the macros and add a blank
> line in front of the test_bit() macros so it's not mixed in with the
> non-atomic macros

Thanks Dan! This makes the kernel a better place.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij