Re: [PATCH] cpufreq: Fix per-policy boost behavior after CPU hotplug
From: kernel test robot
Date: Tue Jun 11 2024 - 17:51:24 EST
Hi PoShao,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge linus/master v6.10-rc3 next-20240611]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/PoShao-Chen/cpufreq-Fix-per-policy-boost-behavior-after-CPU-hotplug/20240611-200804
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20240611115920.28665-1-poshao.chen%40mediatek.com
patch subject: [PATCH] cpufreq: Fix per-policy boost behavior after CPU hotplug
config: sh-defconfig (https://download.01.org/0day-ci/archive/20240612/202406120519.mhrkBEkJ-lkp@xxxxxxxxx/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240612/202406120519.mhrkBEkJ-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406120519.mhrkBEkJ-lkp@xxxxxxxxx/
All error/warnings (new ones prefixed by >>):
drivers/cpufreq/cpufreq.c: In function 'cpufreq_online':
drivers/cpufreq/cpufreq.c:1515:41: warning: missing terminating " character
1515 | pr_info("%s: per-policy boost flag mirror the cpufreq_driver
| ^
drivers/cpufreq/cpufreq.c:1516:48: warning: missing terminating " character
1516 | boost\n", __func__);
| ^
drivers/cpufreq/cpufreq.c:1522:48: warning: missing terminating " character
1522 | pr_err("%s: per-policy boost flag mirror the cpufreq_driver
| ^
drivers/cpufreq/cpufreq.c:1523:63: warning: missing terminating " character
1523 | boost failed\n", __func__);
| ^
>> drivers/cpufreq/cpufreq.c:3092:34: error: unterminated argument list invoking macro "pr_info"
3092 | core_initcall(cpufreq_core_init);
| ^
>> drivers/cpufreq/cpufreq.c:1515:33: error: 'pr_info' undeclared (first use in this function); did you mean 'qc_info'?
1515 | pr_info("%s: per-policy boost flag mirror the cpufreq_driver
| ^~~~~~~
| qc_info
drivers/cpufreq/cpufreq.c:1515:33: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/cpufreq/cpufreq.c:1515:40: error: expected ';' at end of input
1515 | pr_info("%s: per-policy boost flag mirror the cpufreq_driver
| ^
| ;
......
>> drivers/cpufreq/cpufreq.c:1515:33: error: expected declaration or statement at end of input
1515 | pr_info("%s: per-policy boost flag mirror the cpufreq_driver
| ^~~~~~~
>> drivers/cpufreq/cpufreq.c:1515:33: error: expected declaration or statement at end of input
>> drivers/cpufreq/cpufreq.c:1515:33: error: expected declaration or statement at end of input
>> drivers/cpufreq/cpufreq.c:1515:33: error: expected declaration or statement at end of input
>> drivers/cpufreq/cpufreq.c:1493:25: error: label 'out_destroy_policy' used but not defined
1493 | goto out_destroy_policy;
| ^~~~
>> drivers/cpufreq/cpufreq.c:1443:25: error: label 'out_offline_policy' used but not defined
1443 | goto out_offline_policy;
| ^~~~
>> drivers/cpufreq/cpufreq.c:1430:25: error: label 'out_free_policy' used but not defined
1430 | goto out_free_policy;
| ^~~~
>> drivers/cpufreq/cpufreq.c:1417:25: error: label 'out_exit_policy' used but not defined
1417 | goto out_exit_policy;
| ^~~~
>> drivers/cpufreq/cpufreq.c:1383:23: warning: unused variable 'flags' [-Wunused-variable]
1383 | unsigned long flags;
| ^~~~~
drivers/cpufreq/cpufreq.c: At top level:
>> drivers/cpufreq/cpufreq.c:82:21: warning: '__cpufreq_get' used but never defined
82 | static unsigned int __cpufreq_get(struct cpufreq_policy *policy);
| ^~~~~~~~~~~~~
>> drivers/cpufreq/cpufreq.c:83:12: warning: 'cpufreq_init_governor' declared 'static' but never defined [-Wunused-function]
83 | static int cpufreq_init_governor(struct cpufreq_policy *policy);
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/cpufreq/cpufreq.c:84:13: warning: 'cpufreq_exit_governor' declared 'static' but never defined [-Wunused-function]
84 | static void cpufreq_exit_governor(struct cpufreq_policy *policy);
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/cpufreq/cpufreq.c:85:13: warning: 'cpufreq_governor_limits' declared 'static' but never defined [-Wunused-function]
85 | static void cpufreq_governor_limits(struct cpufreq_policy *policy);
| ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/cpufreq/cpufreq.c:86:12: warning: 'cpufreq_set_policy' used but never defined
86 | static int cpufreq_set_policy(struct cpufreq_policy *policy,
| ^~~~~~~~~~~~~~~~~~
>> drivers/cpufreq/cpufreq.c:89:13: warning: 'cpufreq_boost_supported' used but never defined
89 | static bool cpufreq_boost_supported(void);
| ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/cpufreq/cpufreq.c:1379:12: warning: 'cpufreq_online' defined but not used [-Wunused-function]
1379 | static int cpufreq_online(unsigned int cpu)
| ^~~~~~~~~~~~~~
>> drivers/cpufreq/cpufreq.c:1330:13: warning: 'cpufreq_policy_free' defined but not used [-Wunused-function]
1330 | static void cpufreq_policy_free(struct cpufreq_policy *policy)
| ^~~~~~~~~~~~~~~~~~~
drivers/cpufreq/cpufreq.c:1115:12: warning: 'cpufreq_init_policy' defined but not used [-Wunused-function]
1115 | static int cpufreq_init_policy(struct cpufreq_policy *policy)
| ^~~~~~~~~~~~~~~~~~~
drivers/cpufreq/cpufreq.c:1077:12: warning: 'cpufreq_add_dev_interface' defined but not used [-Wunused-function]
1077 | static int cpufreq_add_dev_interface(struct cpufreq_policy *policy)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/cpufreq/cpufreq.c:1069:13: warning: 'remove_cpu_dev_symlink' defined but not used [-Wunused-function]
1069 | static void remove_cpu_dev_symlink(struct cpufreq_policy *policy, int cpu,
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/cpufreq/cpufreq.c:18:
drivers/cpufreq/cpufreq.c:634:22: warning: 'boost' defined but not used [-Wunused-variable]
634 | define_one_global_rw(boost);
| ^~~~~
include/linux/cpufreq.h:332:30: note: in definition of macro 'define_one_global_rw'
332 | static struct kobj_attribute _name = \
| ^~~~~
drivers/cpufreq/cpufreq.c:69:13: warning: 'cpufreq_suspended' defined but not used [-Wunused-variable]
69 | static bool cpufreq_suspended;
| ^~~~~~~~~~~~~~~~~
vim +/pr_info +3092 drivers/cpufreq/cpufreq.c
5a01f2e8f3ac13 Venkatesh Pallipadi 2007-02-05 3069
5a01f2e8f3ac13 Venkatesh Pallipadi 2007-02-05 3070 static int __init cpufreq_core_init(void)
5a01f2e8f3ac13 Venkatesh Pallipadi 2007-02-05 3071 {
8412b4563e5910 Quentin Perret 2020-06-29 3072 struct cpufreq_governor *gov = cpufreq_default_governor();
2744a63c1aec32 Greg Kroah-Hartman 2023-03-13 3073 struct device *dev_root;
8412b4563e5910 Quentin Perret 2020-06-29 3074
a7b422cda5084d Konrad Rzeszutek Wilk 2012-03-13 3075 if (cpufreq_disabled())
a7b422cda5084d Konrad Rzeszutek Wilk 2012-03-13 3076 return -ENODEV;
a7b422cda5084d Konrad Rzeszutek Wilk 2012-03-13 3077
2744a63c1aec32 Greg Kroah-Hartman 2023-03-13 3078 dev_root = bus_get_dev_root(&cpu_subsys);
2744a63c1aec32 Greg Kroah-Hartman 2023-03-13 3079 if (dev_root) {
2744a63c1aec32 Greg Kroah-Hartman 2023-03-13 3080 cpufreq_global_kobject = kobject_create_and_add("cpufreq", &dev_root->kobj);
2744a63c1aec32 Greg Kroah-Hartman 2023-03-13 3081 put_device(dev_root);
2744a63c1aec32 Greg Kroah-Hartman 2023-03-13 3082 }
8aa84ad8d6c740 Thomas Renninger 2009-07-24 3083 BUG_ON(!cpufreq_global_kobject);
8aa84ad8d6c740 Thomas Renninger 2009-07-24 3084
8412b4563e5910 Quentin Perret 2020-06-29 3085 if (!strlen(default_governor))
0faf84caee63a5 Justin Stitt 2023-09-13 3086 strscpy(default_governor, gov->name, CPUFREQ_NAME_LEN);
8412b4563e5910 Quentin Perret 2020-06-29 3087
5a01f2e8f3ac13 Venkatesh Pallipadi 2007-02-05 3088 return 0;
5a01f2e8f3ac13 Venkatesh Pallipadi 2007-02-05 3089 }
d82f26925599ca Len Brown 2017-02-28 3090 module_param(off, int, 0444);
8412b4563e5910 Quentin Perret 2020-06-29 3091 module_param_string(default_governor, default_governor, CPUFREQ_NAME_LEN, 0444);
5a01f2e8f3ac13 Venkatesh Pallipadi 2007-02-05 @3092 core_initcall(cpufreq_core_init);
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki