Re: [PATCH v3 3/3] tracing/kprobe: Remove cleanup code unrelated to selftest

[Google]

On Tue, 11 Jun 2024 10:25:00 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Tue, 11 Jun 2024 22:30:56 +0900
> "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:
> 
> > From: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> > 
> > This cleanup all kprobe events code is not related to the selftest
> > itself, and it can fail by the reason unrelated to this test.
> > If the test is successful, the generated events are cleaned up.
> > And if not, we cannot guarantee that the kprobe events will work
> > correctly. So, anyway, there is no need to clean it up.
> > 
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

Thanks for review!

> 
> -- Steve
> 
> > ---
> >  kernel/trace/trace_kprobe.c |    4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> > index 8c5816c04bd2..7fd0f8576e4c 100644
> > --- a/kernel/trace/trace_kprobe.c
> > +++ b/kernel/trace/trace_kprobe.c
> > @@ -2114,10 +2114,6 @@ static __init int kprobe_trace_self_tests_init(void)
> >  
> >  
> >  end:
> > -	ret = dyn_events_release_all(&trace_kprobe_ops);
> > -	if (WARN_ONCE(ret, "error on cleaning up probes."))
> > -		warn++;
> > -
> >  	/*
> >  	 * Wait for the optimizer work to finish. Otherwise it might fiddle
> >  	 * with probes in already freed __init text.
> 
> 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>