Re: [PATCH v4 0/2] hwmon: (ina2xx):Add Suppor for passing alert polarity from device tree to driver

[Amna Waseem]

On 6/11/24 14:49, Krzysztof Kozlowski wrote:
> On 11/06/2024 11:36, Amna Waseem wrote:
> > The INA230 has alert polarity bit in Mask/Enable register which can be
> > configured to be active high or active low depending upon the requirements
> > of the hardware using this chip. The patches in this series adds the support
> > for passing alert polarity value from device tree to the driver. Alert polarity
> > property is added device tree bindings and the driver is modified to read
> > this property and set the Alert polarity (APOL) bit value in Mask/Enable register
> > of INA230.
> >
> > Signed-off-by: Amna Waseem <Amna.Waseem@xxxxxxxx>
> > ---
> > Changes in v4:
> > - Remove unnecessary checks while setting alert polarity bit
> > - Link to v3: https://lore.kernel.org/r/20240603-apol-ina2xx-fix-v3-0-b9eff3158e4e@xxxxxxxx
> <form letter>
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
>
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
>
> Missing this is really odd, considering you are using b4. Please read
> the b4 guide.
>
> Best regards,
> Krzysztof
Thanks Krzysztof for the information. I have read the documentation in 
the link you provided and I will keep it in mind next time if I submit 
patches.

Regards

Amna