Re: [PATCH 08/14] scsi: fnic: Add functionality in fnic to support FDLS

[Hannes Reinecke]

On 6/10/24 23:50, Karan Tilak Kumar wrote:
> Add interfaces in fnic to use FDLS services.
> Modify link up and link down functionality to use FDLS.
> Replace existing interfaces to handle new functionality
> provided by FDLS.
> Modify data types of some data members to handle new
> functionality.
> Add processing of tports and handling of tports.
>
> Reviewed-by: Sesidhar Baddela <sebaddel@xxxxxxxxx>
> Reviewed-by: Arulprabhu Ponnusamy <arulponn@xxxxxxxxx>
> Reviewed-by: Gian Carlo Boffa <gcboffa@xxxxxxxxx>
> Signed-off-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>
> ---
>   drivers/scsi/fnic/fdls_disc.c |  74 +++++
>   drivers/scsi/fnic/fip.c       |  27 +-
>   drivers/scsi/fnic/fnic.h      |  20 +-
>   drivers/scsi/fnic/fnic_fcs.c  | 498 ++++++++++++++++++++++++----------
>   drivers/scsi/fnic/fnic_main.c |  10 +-
>   drivers/scsi/fnic/fnic_scsi.c | 127 +++++++--
>   6 files changed, 587 insertions(+), 169 deletions(-)
This seems to not just _add_ the functionality to use FDLS, but rather 
_replace_ the existing functionality with FDLS.
IE it seems that after this change the driver will always do FDLS, 
causing a possible service interruption with existing setups.
Hmm?

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxx                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich