Re: [PATCH v3 1/3] media: dt-bindings: i2c: add Giantec GT97xx VCM

[AngeloGioacchino Del Regno]

Il 12/06/24 03:20, Zhi Mao ha scritto:
> Add YAML device tree binding for GT9768 & GT9769 VCM,
> and the relevant MAINTAINERS entries.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Zhi Mao <zhi.mao@xxxxxxxxxxxx>
> ---
>   .../bindings/media/i2c/giantec,gt9769.yaml    | 55 +++++++++++++++++++
>   1 file changed, 55 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/media/i2c/giantec,gt9769.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/giantec,gt9769.yaml b/Documentation/devicetree/bindings/media/i2c/giantec,gt9769.yaml
> new file mode 100644
> index 000000000000..92d603acc53c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/giantec,gt9769.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (c) 2020 MediaTek Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/giantec,gt9769.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Giantec Semiconductor, Crop. GT9768 & GT9769 Voice Coil Motor (VCM)
> +
> +maintainers:
> +  - Zhi Mao <zhi.mao@xxxxxxxxxxxx>
> +
> +description:
> +  The Giantec GT9768 & GT9769 is a 10-bit DAC with current sink capability.
> +  The DAC is controlled via I2C bus that operates at clock rates up to 1MHz.
> +  This chip integrates Advanced Actuator Control (AAC) technology
> +  and is intended for driving voice coil lens in camera modules.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - giantec,gt9768

Can't you simply add the "giantec,gt9768" compatible to dongwoon,dw9768.yaml?

Regards,
Angelo