Re: ANNOUNCE: pahole v1.27 (reproducible builds, BTF kfuncs)

From: Matthias Schwarzott
Date: Wed Jun 12 2024 - 06:07:31 EST


Am 11.06.24 um 23:26 schrieb Arnaldo Carvalho de Melo:
Hi,
The v1.27 release of pahole and its friends is out, supporting
parallel reproducible builds and encoding kernel kfuncs in BTF, allowing
tools such as bpftrace to enumerate the available kfuncs and obtain its
function signatures and return types.


Regarding packaging of pahole:
What is the state of the contained ostra-cg?
I have no clue what it is and how to use it. Is there still a use-case for it?

Starting it without arguments only shows the usage string.
Running it with two dummy arguments:
$ ostra-cg x y
Traceback (most recent call last):
File "/usr/bin/ostra-cg", line 404, in <module>
class_def = ostra.class_definition(class_def_file = "%s.fields" % traced_class,

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/dwarves/runtime/python/ostra.py", line 154, in __init__
f = file(class_def_file)
^^^^
NameError: name 'file' is not defined. Did you mean: 'field'?

According to https://stackoverflow.com/questions/32131230/python-file-function the function file() does not exist in python3.

This part could be fixed by replacing it with open() but I wonder if this is worth it.

As nobody has complained about it being broken:
Should ostra just be removed?

Regards
Matthias