Re: [PATCH] selftests: mm: Make map_fixed_noreplace test names stable

[Mark Brown]

On Tue, Jun 11, 2024 at 03:23:17PM -0700, Andrew Morton wrote:
> On Wed, 05 Jun 2024 23:36:12 +0100 Mark Brown <broonie@xxxxxxxxxx> wrote:

> > KTAP parsers interpret the output of ksft_test_result_*() as being the
> > name of the test.  The map_fixed_noreplace test uses a dynamically
> > allocated base address for the mmap()s that it tests and currently
> > includes this in the test names that it logs so the test names that are
> > logged are not stable between runs.  It also uses multiples of PAGE_SIZE
> > which mean that runs for kernels with different PAGE_SIZE configurations
> > can't be directly compared.  Both these factors cause issues for CI
> > systems when interpreting and displaying results.

> > Fix this by replacing the current test names with fixed strings
> > describing the intent of the mappings that are logged, the existing
> > messages with the actual addresses and sizes are retained as diagnostic
> > prints to aid in debugging.

> This sounds fairly annoying and I'm inclined to backport the fix into
> -stable kernels(?).

It's annoying but more of a UI issue than anything too serious - for my
setup it just translates into not validating those individual tests and
instead only paying attention to the overall result of the program.
Personally I'd say that it reaches the severity where it might be worth
sending for v6.10 but not to stable.

Attachment: signature.asc
Description: PGP signature