Re: [PATCH v2] dt-bindings: serial: vt8500-uart: convert to json-schema

From: Krzysztof Kozlowski
Date: Wed Jun 12 2024 - 11:11:22 EST


On 12/06/2024 16:29, Kanak Shilledar wrote:
> Convert the VIA VT8500 and WonderMedia WM8xxx UART Controller to
> newer DT schema. Created DT schema based on the .txt file which had
> `compatible`, `reg`, `interrupts` and `clocks` as required properties.
>
> Additions to the original binding
> - changed the file name from vt8500-uart to via,vt8500-uart.yaml
> - removed unnecessary alias from the example.
> - added Greg and Jiri as maintainers (referred MAINTAINERS file).

?

>
> Signed-off-by: Kanak Shilledar <kanakshilledar@xxxxxxxxx>
> ---
> Changes in v2:
> - Rebased changes
> - Changed maintainers to have Rob. VT8500 is orphaned according
> to the maintainers file.
> - Replaced `compatible` property description with comments.


> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/via,vt8500-uart.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VIA VT8500 and WonderMedia WM8xxx UART Controller
> +
> +maintainers:
> + - Rob Herring <robh@xxxxxxxxxx>

Not Rob.

> + - Kanak Shilledar <kanakshilledar111@xxxxxxxxxxxxxx>

I doubt you care about this device. This could be most recent
contributor, so: Alexey Charkov <alchark@xxxxxxxxx>


> +
> +allOf:
> + - $ref: serial.yaml
> +
> +properties:
> + compatible:
> + enum:
> + - via,vt8500-uart # up to WM8850/WM8950
> + - wm,wm8880-uart # for WM8880 and later


Best regards,
Krzysztof