Re: [PATCH] block: sed-opal: avoid possible wrong address reference in read_sed_opal_key()

From: Jens Axboe
Date: Wed Jun 12 2024 - 13:01:07 EST



On Tue, 11 Jun 2024 15:37:00 +0800, Su Hui wrote:
> Clang static checker (scan-build) warning:
> block/sed-opal.c:line 317, column 3
> Value stored to 'ret' is never read.
>
> Fix this problem by returning the error code when keyring_search() failed.
> Otherwise, 'key' will have a wrong value when 'kerf' stores the error code.
>
> [...]

Applied, thanks!

[1/1] block: sed-opal: avoid possible wrong address reference in read_sed_opal_key()
commit: 9b1ebce6a1fded90d4a1c6c57dc6262dac4c4c14

Best regards,
--
Jens Axboe