Re: [RFC PATCH net-next 0/9] flower: rework TCA_FLOWER_KEY_ENC_FLAGS usage

[Asbjørn Sloth Tønnesen]

Hi Davide,

On 6/12/24 3:06 PM, Davide Caratti wrote:
> On Tue, Jun 11, 2024 at 11:53:33PM +0000, Asbjørn Sloth Tønnesen wrote:
> > This series reworks the recently added TCA_FLOWER_KEY_ENC_FLAGS
> > attribute, to be more like TCA_FLOWER_KEY_FLAGS, and use
> > the unused u32 flags field in TCA_FLOWER_KEY_ENC_CONTROL,
> > instead of adding another u32 in FLOW_DISSECTOR_KEY_ENC_FLAGS.

s/TCA_FLOWER_KEY_ENC_CONTROL/FLOW_DISSECTOR_KEY_ENC_CONTROL/

> > I have defined the new FLOW_DIS_F_* and TCA_FLOWER_KEY_FLAGS_*
> > flags to coexists for now, so the meaning of the flags field
> > in struct flow_dissector_key_control is not depending on the
> > context that it is used in. If we run out of bits then we can
> > always make split them up later, if we really want to.

s/always make split/always split/

> > Davide and Ilya would this work for you?
>
> If you are ok with this, I can adjust the iproute code I keep locally,
> and the kselftest, re-test, and than report back to the series total
> reviewed-by.
> It's going a take some days though; and of course, those bit will be
> upstreamed as well.
>
> WDYT?

That would be great, there is still quite some time left before net-next
closes, I just wanted to get the ball rolling, with some code, so it is
easier to discuss the implementation details.

--
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541