Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared on link-down

From: Andrew Lunn
Date: Wed Jun 12 2024 - 15:16:38 EST


On Tue, Jun 11, 2024 at 10:04:05AM +0200, Csókás, Bence wrote:
> FEC_ECR_EN1588 bit gets cleared after MAC reset in `fec_stop()`, which
> makes all 1588 functionality shut down, and all the extended registers
> disappear, on link-down, making the adapter fall back to compatibility
> "dumb mode". However, some functionality needs to be retained (e.g. PPS)
> even without link.
>
> Fixes: 6605b730c061 ("FEC: Add time stamping code and a PTP hardware clock")
> Cc: Richard Cochran <richardcochran@xxxxxxxxx>
>
> Signed-off-by: Csókás, Bence <csokas.bence@xxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew