Re: [PATCH 1/2] kconfig: add -e and -u options to *conf-cfg.sh scripts

From: Nicolas Schier
Date: Wed Jun 12 2024 - 15:29:06 EST


On Wed, Jun 12, 2024 at 01:08:05AM +0900, Masahiro Yamada wrote:
> Set -e to make these scripts fail on the first error.
>
> Set -u because these scripts are invoked by Makefile, and do not work
> properly without necessary variables defined.
>
> Both options are described in POSIX. [1]
>
> [1]: https://pubs.opengroup.org/onlinepubs/009604499/utilities/set.html
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---

Thanks, I think 'set -eu' is really a good thing. Would like to see it
in even more scripts below scripts/.

Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>

Kind regards,
Nicolas