Re: [PATCH 1/1] PCI: Remove extra parenthesis from calculate_mem_align()

From: Bjorn Helgaas
Date: Wed Jun 12 2024 - 15:52:00 EST


On Wed, Jun 12, 2024 at 12:32:49PM +0300, Ilpo Järvinen wrote:
> RHS of <<= does not need parenthesis so remove them.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Squashed, thanks!

> ---
>
> This patch can be folded into the commit 658bf5d36dc5 ("PCI: Make
> minimum bridge window alignment reference more obvious") in
> pci/resource if so desired.
> ---
> drivers/pci/setup-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> index 11ee60b9ca71..23082bc0ca37 100644
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@ -960,7 +960,7 @@ static inline resource_size_t calculate_mem_align(resource_size_t *aligns,
> for (order = 0; order <= max_order; order++) {
> resource_size_t align1 = 1;
>
> - align1 <<= (order + __ffs(SZ_1M));
> + align1 <<= order + __ffs(SZ_1M);
>
> if (!align)
> min_align = align1;
> --
> 2.39.2
>