Re: [RFC v1 2/3] spi: microchip-core-qspi: Add regular transfers

From: Conor Dooley
Date: Wed Jun 12 2024 - 16:48:30 EST


On Wed, Jun 12, 2024 at 05:40:39PM +0100, Mark Brown wrote:
> On Wed, Jun 12, 2024 at 04:48:32PM +0100, Conor Dooley wrote:
>
> > + //TODO: questionable robustness if both cs_change and cs_off toggle
> > + list_for_each_entry(t, &m->transfers, transfer_list) {
> > + //cs_change being set means we need to re-enable
>
> Is it not possible to implement prepare_message() and transfer_one()
> rather than open coding all this?

If I can, I will. I already found one issue with the cs toggling in the
code Cyril gave me and I need to figure out why there's a udelay(750)
required later on in the function anyway!

Attachment: signature.asc
Description: PGP signature