Re: [PATCH v3 2/2] arm64: dts: rockchip: Add FriendlyElec CM3588 NAS board

[me]

On 10.06.2024 00:20, Sebastian Kropatsch wrote:
> The CM3588 NAS by FriendlyElec pairs the CM3588 compute module, based on
> the Rockchip RK3588 SoC, with the CM3588 NAS Kit carrier board.
> To reflect the hardware setup, add device tree sources for the SoM and
> the NAS daughter board as separate files.
>
> Hardware features:
>      - Rockchip RK3588 SoC
>      - 4GB/8GB/16GB LPDDR4x RAM
>      - 64GB eMMC
>      - MicroSD card slot
>      - 1x RTL8125B 2.5G Ethernet
>      - 4x M.2 M-Key with PCIe 3.0 x1 (via bifurcation) for NVMe SSDs
>      - 2x USB 3.0 (USB 3.1 Gen1) Type-A, 1x USB 2.0 Type-A
>      - 1x USB 3.0 Type-C with DP AltMode support
>      - 2x HDMI 2.1 out, 1x HDMI in
>      - MIPI-CSI Connector, MIPI-DSI Connector
>      - 40-pin GPIO header
>      - 4 buttons: power, reset, recovery, MASK, user button
>      - 3.5mm Headphone out, 2.0mm PH-2A Mic in
>      - 5V Fan connector, PWM buzzer, IR receiver, RTC battery connector
>
> PCIe bifurcation is used to handle all four M.2 sockets at PCIe 3.0 x1
> speed. Data lane mapping in the DT is done like described in commit
> f8020dfb311d ("phy: rockchip-snps-pcie3: fix bifurcation on rk3588").
>
> This device tree includes support for eMMC, SD card, ethernet, all USB2
> and USB3 ports, all four M.2 slots, GPU, RTC, buzzer, UART debugging as
> well as the buttons and LEDs.
> The GPIOs are labeled according to the schematics.
>
> Signed-off-by: Sebastian Kropatsch <seb-dev@xxxxxxx>
> ---
>   arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>   .../rk3588-friendlyelec-cm3588-nas.dts        | 759 ++++++++++++++++++
>   .../rockchip/rk3588-friendlyelec-cm3588.dtsi  | 655 +++++++++++++++
>   3 files changed, 1415 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts
>   create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588.dtsi


Reviewed-by: Space Meyer <git@the-space.agency>

Confirmed v3 fixed the usb-c port. I only tested with a single USB 2 
device, as I'm not home at the moment and don't have many options to 
test things here.

Cheers,
Space