Re: [PATCH v1] net: mvpp2: use slab_build_skb for oversized frames

From: Aryan Srivastava
Date: Wed Jun 12 2024 - 23:13:47 EST


On Wed, 2024-06-12 at 20:05 -0700, Kees Cook wrote:
> On Thu, Jun 13, 2024 at 02:49:00PM +1200, Aryan Srivastava wrote:
> > Setting frag_size to 0 to indicate kmalloc has been deprecated,
> > use slab_build_skb directly.
> >
> > Fixes: ce098da1497c ("skbuff: Introduce slab_build_skb()")
> > Signed-off-by: Aryan Srivastava
> > <aryan.srivastava@xxxxxxxxxxxxxxxxxxx>
> > ---
> > Changes in v1:
> > - Added Fixes tag
>
> This looks like similar updates like commit 99b415fe8986 ("tg3: Use
> slab_build_skb() when needed")
Yeah, I noticed that when I was looking for examples of other "Fixes"
tags for the "skbuff: Introduce slab_build_skb()" commit. I suspect
there are many drivers that will need this "fix".
>
> Reviewed-by: Kees Cook <kees@xxxxxxxxxx>
>