Re: [PATCH v3 0/2] usercopy: Convert test_user_copy to KUnit test

[David Gow]

On Thu, 13 Jun 2024 at 03:59, Kees Cook <kees@xxxxxxxxxx> wrote:
>
> Hi,
>
> This builds on the proposal[1] from Mark and lets me convert the
> existing usercopy selftest to KUnit. Besides adding this basic test to
> the KUnit collection, it also opens the door for execve testing (which
> depends on having a functional current->mm), and should provide the
> basic infrastructure for adding Mark's much more complete usercopy tests.
>
>  v3:
>   - use MEMEQ KUnit helper (David)
>   - exclude pathological address confusion test for systems with separate
>     address spaces, noticed by David
>   - add KUnit-conditional exports for alloc_mm() and arch_pick_mmap_layout()
>     noticed by 0day
>  v2: https://lore.kernel.org/lkml/20240610213055.it.075-kees@xxxxxxxxxx/
>  v1: https://lore.kernel.org/lkml/20240519190422.work.715-kees@xxxxxxxxxx/
>
> -Kees
>
> [1] https://lore.kernel.org/lkml/20230321122514.1743889-2-mark.rutland@xxxxxxx/

Thanks! This looks good to me (and passes everything here). Unless
there's a compelling reason not to, I think we can take this via the
KUnit tree.

Cheers,
-- David

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature