Re: [PATCH v2 1/4] kernfs: remove page_mkwrite() from vm_operations_struct

From: Christoph Hellwig
Date: Thu Jun 13 2024 - 01:44:33 EST


On Tue, Jun 11, 2024 at 12:27:29PM -0600, Martin Oliveira wrote:
> + if (vma->vm_ops->page_mkwrite)
> + goto out_put;
> +

I'd probably make this a WARN_ON so that driver authors trying to
add a page_mkwrite in the vm_ops passed to kernfs get a big fat
warning instead of spending a couple hours trying to track down
what is going wrong :)