Re: [PATCH net V4 2/3] net: lan743x: Support WOL at both the PHY and MAC appropriately

[Horatiu Vultur]

The 06/12/2024 22:55, Raju Lakkaraju wrote:

Hi Raju,

> Prevent options not supported by the PHY from being requested to it by the MAC
> Whenever a WOL option is supported by both, the PHY is given priority
> since that usually leads to better power savings.
> 
> Fixes: e9e13b6adc338 ("lan743x: fix for potential NULL pointer dereference with bare card")

I am not sure if you run checkpatch.pl, but this gives you a warning.
The sha has too many chars.

> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@xxxxxxxxxxxxx>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@xxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406052200.w3zuc32H-lkp@xxxxxxxxx/

I still don't think you should add the 'Reported-by' and 'Closes' tags
here because you introduced the issue in first V3 of this patch series.
Because the intel robot says: "If you fix the issue in a separate
patch/commit (i.e. not just a new version of the same patch/commit),
kindly add following tags".

-- 
/Horatiu