Re: [PATCH v7 1/4] mm/rmap: remove duplicated exit code in pagewalk loop

[David Hildenbrand]

On 13.06.24 09:52, Barry Song wrote:
> On Tue, Jun 11, 2024 at 12:02 AM Lance Yang <ioworker0@xxxxxxxxx> wrote:
> > Introduce the labels walk_done and walk_done_err as exit points to
> > eliminate duplicated exit code in the pagewalk loop.
> >
> > Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>
> > Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
> > Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
> > Signed-off-by: Lance Yang <ioworker0@xxxxxxxxx>
>
> I don't think "return false" necessarily indicates an error, so
> "walk_done_err" doesn't seem like an appropriate name.
> However, this is a minor issue.

Agreed. As we only have a single walk_done user, should we instead 
remove "walk_done", keep the "page_vma_mapped_walk_done" for that single 
user, and rename "walk_done_err" to "abort_walk" ?


--
Cheers,

David / dhildenb