Re: [PATCH v5 2/3] drm/bridge: sii902x: Support atomic bridge APIs

[Aradhya Bhatia]

On 13-Jun-24 14:08, Jayesh Choudhary wrote:
> Change exisitig enable() and disable() bridge hooks to their atomic
> counterparts as the former hooks are deprecated.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@xxxxxx>
> ---
>  drivers/gpu/drm/bridge/sii902x.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> index 6a6055a4ccf9..00a8c469f553 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -322,7 +322,8 @@ static const struct drm_connector_helper_funcs sii902x_connector_helper_funcs =
>  	.get_modes = sii902x_get_modes,
>  };
>  
> -static void sii902x_bridge_disable(struct drm_bridge *bridge)
> +static void sii902x_bridge_atomic_disable(struct drm_bridge *bridge,
> +					  struct drm_bridge_state *old_bridge_state)
>  {
>  	struct sii902x *sii902x = bridge_to_sii902x(bridge);
>  
> @@ -335,7 +336,8 @@ static void sii902x_bridge_disable(struct drm_bridge *bridge)
>  	mutex_unlock(&sii902x->mutex);
>  }
>  
> -static void sii902x_bridge_enable(struct drm_bridge *bridge)
> +static void sii902x_bridge_atomic_enable(struct drm_bridge *bridge,
> +					 struct drm_bridge_state *old_bridge_state)
>  {
>  	struct sii902x *sii902x = bridge_to_sii902x(bridge);
>  
> @@ -520,8 +522,8 @@ sii902x_bridge_mode_valid(struct drm_bridge *bridge,
>  static const struct drm_bridge_funcs sii902x_bridge_funcs = {
>  	.attach = sii902x_bridge_attach,
>  	.mode_set = sii902x_bridge_mode_set,
> -	.disable = sii902x_bridge_disable,
> -	.enable = sii902x_bridge_enable,
> +	.atomic_disable = sii902x_bridge_atomic_disable,
> +	.atomic_enable = sii902x_bridge_atomic_enable,
>  	.detect = sii902x_bridge_detect,
>  	.edid_read = sii902x_bridge_edid_read,
>  	.atomic_reset = drm_atomic_helper_bridge_reset,

Reviewed-by: Aradhya Bhatia <a-bhatia1@xxxxxx>

-- 
Regards
Aradhya