Re: [PATCH v2 0/2] ASoC: codecs: lpass: add support for v2.5 rx macro

From: neil . armstrong
Date: Thu Jun 13 2024 - 06:18:54 EST


On 06/06/2024 14:25, srinivas.kandagatla@xxxxxxxxxx wrote:
From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

This patchset adds support to reading codec version and also adds
support for v2.5 codec version in rx macro.

LPASS 2.5 and up versions have changes in some of the rx blocks which
are required to get headset functional correctly.

Tested this on SM8450, X13s and x1e80100 crd.

This changes also fixes issue with sm8450, sm8550, sm8660 and x1e80100.

@Neil Armstrong can you pl test it on sm8650

@Krzysztof Kozlowski can you pl test it on sm8550

Thanks,
Srini

Changes since v1:
- renamed all 2_6 variables with 2.5
- expanded checks for versions from 2.5 till 2.8

Srinivas Kandagatla (2):
ASoC: codecs: lpass-macro: add helpers to get codec version
ASoC: codec: lpass-rx-macro: add suppor for 2.5 codec version

sound/soc/codecs/lpass-macro-common.c | 14 +
sound/soc/codecs/lpass-macro-common.h | 35 ++
sound/soc/codecs/lpass-rx-macro.c | 565 +++++++++++++++++++-------
sound/soc/codecs/lpass-va-macro.c | 29 ++
4 files changed, 488 insertions(+), 155 deletions(-)


Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> # on SM8650-HDK

Successfully fixes dual channel output on headset, previously I would only hear
sound on a single channel.

Thanks,
Neil