Re: [PATCH v2] arm64: dts: qcom: qdu/qru1000-idp: Fix the voltage setting

[Komal Bajaj]

On 5/24/2024 2:59 PM, Dmitry Baryshkov wrote:
> On Fri, 24 May 2024 at 11:23, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote:
> > While adding the USB support, it was found that the configuration
> > for regulator smps5 was incorrectly set. Upon cross verifying for
> > all the regulators, found that smps4, smps6 and smps8 are also
> > incorrectly configured. This patch fixes the same.
>
> Nit: see Documentation/process/submitting-patches.rst, "This patch..."

Will update the commit message.

> > In particular -
> > - smps4 is 1.574V min and 2.04V max
> > - smps5 is 1.2V min and 1.4V max
> > - smps6 is 0.382V min and 1.12V max
>
> Just for my understanding, will anything further constraint these values?

As far as i know, this is going to be final.
currently, usb device is not working without this min/max change.

Thanks
Komal

> > - smps8 is fixed at 0.752V
> >
> > Fixes: d1f2cfe2f669 ("arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs")
> > Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>
> > ---
> > Changes in v2-
> > * Updated the commit message as suggested by Krzysztof
> > * Link to v1: https://lore.kernel.org/linux-arm-msm/20240514131038.28036-1-quic_kbajaj@xxxxxxxxxxx/
> > ---
> >
> >   arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 16 ++++++++--------
> >   arch/arm64/boot/dts/qcom/qru1000-idp.dts | 16 ++++++++--------
> >   2 files changed, 16 insertions(+), 16 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > index 6e129dc123ed..89b84fb0f70a 100644
> > --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > @@ -96,20 +96,20 @@ vreg_s3a_1p05: smps3 {
> >
> >                  vreg_s4a_1p8: smps4 {
> >                          regulator-name = "vreg_s4a_1p8";
> > -                       regulator-min-microvolt = <1800000>;
> > -                       regulator-max-microvolt = <1800000>;
> > +                       regulator-min-microvolt = <1574000>;
> > +                       regulator-max-microvolt = <2040000>;
> >                  };
> >
> >                  vreg_s5a_2p0: smps5 {
> >                          regulator-name = "vreg_s5a_2p0";
> > -                       regulator-min-microvolt = <1904000>;
> > -                       regulator-max-microvolt = <2000000>;
> > +                       regulator-min-microvolt = <1200000>;
> > +                       regulator-max-microvolt = <1400000>;
> >                  };
> >
> >                  vreg_s6a_0p9: smps6 {
> >                          regulator-name = "vreg_s6a_0p9";
> > -                       regulator-min-microvolt = <920000>;
> > -                       regulator-max-microvolt = <1128000>;
> > +                       regulator-min-microvolt = <382000>;
> > +                       regulator-max-microvolt = <1120000>;
> >                  };
> >
> >                  vreg_s7a_1p2: smps7 {
> > @@ -120,8 +120,8 @@ vreg_s7a_1p2: smps7 {
> >
> >                  vreg_s8a_1p3: smps8 {
> >                          regulator-name = "vreg_s8a_1p3";
> > -                       regulator-min-microvolt = <1352000>;
> > -                       regulator-max-microvolt = <1352000>;
> > +                       regulator-min-microvolt = <752000>;
> > +                       regulator-max-microvolt = <752000>;
> >                  };
> >
> >                  vreg_l1a_0p91: ldo1 {
> > diff --git a/arch/arm64/boot/dts/qcom/qru1000-idp.dts b/arch/arm64/boot/dts/qcom/qru1000-idp.dts
> > index 2a862c83309e..258483af065b 100644
> > --- a/arch/arm64/boot/dts/qcom/qru1000-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/qru1000-idp.dts
> > @@ -96,20 +96,20 @@ vreg_s3a_1p05: smps3 {
> >
> >                  vreg_s4a_1p8: smps4 {
> >                          regulator-name = "vreg_s4a_1p8";
> > -                       regulator-min-microvolt = <1800000>;
> > -                       regulator-max-microvolt = <1800000>;
> > +                       regulator-min-microvolt = <1574000>;
> > +                       regulator-max-microvolt = <2040000>;
> >                  };
> >
> >                  vreg_s5a_2p0: smps5 {
> >                          regulator-name = "vreg_s5a_2p0";
> > -                       regulator-min-microvolt = <1904000>;
> > -                       regulator-max-microvolt = <2000000>;
> > +                       regulator-min-microvolt = <1200000>;
> > +                       regulator-max-microvolt = <1400000>;
> >                  };
> >
> >                  vreg_s6a_0p9: smps6 {
> >                          regulator-name = "vreg_s6a_0p9";
> > -                       regulator-min-microvolt = <920000>;
> > -                       regulator-max-microvolt = <1128000>;
> > +                       regulator-min-microvolt = <382000>;
> > +                       regulator-max-microvolt = <1120000>;
> >                  };
> >
> >                  vreg_s7a_1p2: smps7 {
> > @@ -120,8 +120,8 @@ vreg_s7a_1p2: smps7 {
> >
> >                  vreg_s8a_1p3: smps8 {
> >                          regulator-name = "vreg_s8a_1p3";
> > -                       regulator-min-microvolt = <1352000>;
> > -                       regulator-max-microvolt = <1352000>;
> > +                       regulator-min-microvolt = <752000>;
> > +                       regulator-max-microvolt = <752000>;
> >                  };
> >
> >                  vreg_l1a_0p91: ldo1 {
> > --
> > 2.42.0