Re: [PATCH net-next v5 06/12] net: dsa: lantiq_gswip: do also enable or disable cpu port

From: Vladimir Oltean
Date: Thu Jun 13 2024 - 08:02:44 EST


On Tue, Jun 11, 2024 at 03:54:28PM +0200, Martin Schiller wrote:
> Before commit 74be4babe72f ("net: dsa: do not enable or disable non user
> ports"), gswip_port_enable/disable() were also executed for the cpu port
> in gswip_setup() which disabled the cpu port during initialization.
>
> Let's restore this by removing the dsa_is_user_port checks. Also, let's
> clean up the gswip_port_enable() function so that we only have to check
> for the cpu port once. The operation reordering done here is safe.
>
> Signed-off-by: Martin Schiller <ms@xxxxxxxxxx>
> Acked-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
> ---

Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>