Re: [PATCH net-next v5 09/12] net: dsa: lantiq_gswip: Consistently use macros for the mac bridge table

[Vladimir Oltean]

On Tue, Jun 11, 2024 at 03:54:31PM +0200, Martin Schiller wrote:
> From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> 
> Only bits [5:0] in mac_bridge.key[3] are reserved for the FID.
> Also, for dynamic (learned) entries, bits [7:4] in mac_bridge.val[0]
> represents the port.
> 
> Introduce new macros GSWIP_TABLE_MAC_BRIDGE_KEY3_FID and
> GSWIP_TABLE_MAC_BRIDGE_VAL0_PORT macro and use it throughout the driver.
> Also rename and update GSWIP_TABLE_MAC_BRIDGE_VAL1_STATIC to use the
> BIT() macro. This makes the driver code easier to understand.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Signed-off-by: Martin Schiller <ms@xxxxxxxxxx>
> Acked-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
> ---

Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>