Re: [PATCH v7 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

[Lee Jones]

On Fri, 31 May 2024, Karel Balej wrote:

> Support the LDO and buck regulators of the Marvell 88PM886 PMIC.
> 
> Signed-off-by: Karel Balej <balejk@xxxxxxxxx>
> ---
> 
> Notes:
>     v7:
>     - Address Mark's feedback:
>       - Drop get_current_limit op, max_uA values and thus unneeded struct
>         pm886_regulator and adapt the code accordingly.
>     v6:
>     - Remove all definitions (now present in the header).
>     v5:
>     - Add remaining regulators.
>     - Clean up includes.
>     - Address Mark's feedback:
>       - Use dedicated regmap config.
>     RFC v4:
>     - Initialize regulators regmap in the regulators driver.
>     - Register all regulators at once.
>     - Drop regulator IDs.
>     - Add missing '\n' to dev_err_probe message.
>     - Fix includes.
>     - Add ID table.
>     RFC v3:
>     - Do not have a variable for each regulator -- define them all in the
>       pm886_regulators array.
>     - Use new regulators regmap index name.
>     - Use dev_err_probe.
>     RFC v2:
>     - Drop of_compatible and related code.
>     - Drop unused include.
>     - Remove some abstraction: use only one regmap for all regulators and
>       only mention 88PM886 in Kconfig description.
>     - Reword commit message.
> 
>  drivers/regulator/88pm886-regulator.c | 392 ++++++++++++++++++++++++++
>  drivers/regulator/Kconfig             |   6 +
>  drivers/regulator/Makefile            |   1 +
>  3 files changed, 399 insertions(+)
>  create mode 100644 drivers/regulator/88pm886-regulator.c

I'm fine with this set - just waiting for Mark to review.

-- 
Lee Jones [李琼斯]