Re: [PATCH v3 3/4] platform/chrome: cros_kbd_led_backlight: allow binding through mfd device

From: Lee Jones
Date: Thu Jun 13 2024 - 10:35:14 EST


On Mon, 03 Jun 2024, Tzung-Bi Shih wrote:

> On Sun, May 26, 2024 at 08:17:17PM +0200, Thomas Weißschuh wrote:
> > The ChromeOS EC used in Framework laptops supports the standard CrOS EC
> > keyboard backlight protocol.
> > However the firmware on these laptops doesn't implement the ACPI ID
> > GOOG0002 that is recognized by cros_kbd_led_backlight and they also
> > don't use device tree.
> >
> > Prepare the existing cros_kbd_led_backlight driver to be probed through
> > the CrOS EC mfd device which works without ACPI or OF support.
> >
> > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
>
> The patch overall looks good to me but it depends on previous patch in the
> series (for LED_REJECT_NAME_CONFLICT). Let's wait for review.

I plan to take this via MFD.

Is someone going to Ack this patch?

--
Lee Jones [李琼斯]