Re: [PATCH 2/5] PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers

From: Markus Elfring
Date: Thu Jun 13 2024 - 11:48:46 EST



> +++ b/drivers/pci/endpoint/pci-epc-core.c

> +void pci_epc_deinit_notify(struct pci_epc *epc)
> +{

> + mutex_lock(&epc->list_lock);
> + list_for_each_entry(epf, &epc->pci_epf, list) {
> + mutex_lock(&epf->lock);
> + if (epf->event_ops && epf->event_ops->epc_deinit)
> + epf->event_ops->epc_deinit(epf);
> + mutex_unlock(&epf->lock);
> + }
> + epc->init_complete = false;
> + mutex_unlock(&epc->list_lock);
> +}


Would you become interested to apply lock guards?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196

Regards,
Markus