Re: [PATCH] virt: tdx-guest: Fix the decrypted failure memory free

From: Edgecombe, Rick P
Date: Thu Jun 13 2024 - 12:21:48 EST


On Thu, 2024-06-13 at 09:07 -0700, Dave Hansen wrote:
> Second, Rick was looking in this area, but I'm not sure we ever applied
> his patches.  The idea was to never leak memory silently in these
> failures.  Doesn't this silently leak memory?

They did get applied actually. After a fair amount of discussion the solution
was to always leak the pages, and rely on the WARN that happens in set_memory()
to make noise about it.

It looks like this instance popped up after the sweep through the code was done.
(at least in my local branch with the patches for the fixes, this code was not
merged yet)