Re: [PATCH] ARM: dts: qcom: motorola-falcon: add accelerometer, magnetometer

From: Konrad Dybcio
Date: Thu Jun 13 2024 - 13:21:30 EST




On 6/13/24 19:18, Stanislav Jakubek wrote:
On Thu, Jun 13, 2024 at 09:48:26AM +0200, Konrad Dybcio wrote:


On 6/9/24 13:05, Stanislav Jakubek wrote:
Add the accelerometer and magnetometer that are present on the Motorola
Moto G (2013) device.

Signed-off-by: Stanislav Jakubek <stano.jakubek@xxxxxxxxx>
---

[...]

+&blsp1_i2c2 {

Consider setting a clock-frequency = <>

Hi Konrad,

checking downstream [1], qcom,i2c-bus-freq for I2C2 is 100000, which seems
to be the default. Should I specify it anyway?

Yes, at the very least to silence the dmesg warning ;)

Konrad