Re: [PATCH v6 2/2] pstore/ramoops: Add ramoops.mem_name= command line option

From: Guilherme G. Piccoli
Date: Thu Jun 13 2024 - 14:20:20 EST


Thanks Steve, re-tested in my VM and it's working fine.
Just a minor below...


On 13/06/2024 12:55, Steven Rostedt wrote:
> [...]
> + D. Using a region of memory reserved via ``reserve_mem`` command line
> + parameter. The address and size will be defined by the ``reserve_mem``
> + parameter. Note, that ``reserve_mem`` may not always allocate memory
> + in the same location, and cannot be relied upon. Testing will need
> + to be done, and it may not work on every machine, nor every kernel.
> + Consider this a "best effort" approach. The ``reserve_mem`` option
> + takes a size, alignment and name as arguments. The name is used
> + to map the memory to a label that can be retrieved by ramoops.
> +
> + reserver_mem=2M:4096:oops ramoops.mem_name=oops
> +

Likely this could be fixed on merge, to avoid another version, but...

s/reserver_mem/reserve_mem


Cheers!