Re: [PATCH v7 10/13] PCI: Give pci(m)_intx its own devres callback

From: Bjorn Helgaas
Date: Thu Jun 13 2024 - 14:47:24 EST


On Thu, Jun 13, 2024 at 08:23:26PM +0300, Ilpo Järvinen wrote:
> On Wed, 5 Jun 2024, Philipp Stanner wrote:
>
> > pci_intx() is one of the functions that have "hybrid mode" (i.e.,
> > sometimes managed, sometimes not). Providing a separate pcim_intx()
> > function with its own device resource and cleanup callback allows for
> > removing further large parts of the legacy PCI devres implementation.

> > +/* Used to restore the old intx state on driver detach. */
>
> INTx

Updated locally in v9 series.

> > @@ -392,32 +397,75 @@ int pcim_set_mwi(struct pci_dev *pdev)
> > }
> > EXPORT_SYMBOL(pcim_set_mwi);
> >
> > +
> > static inline bool mask_contains_bar(int mask, int bar)
>
> Stray change.

Updated locally in v9 series.