Re: [PATCH] KVM: nVMX: Update VMCS12_REVISION comment to state it should never change

From: Jim Mattson
Date: Thu Jun 13 2024 - 15:29:03 EST


On Thu, Jun 13, 2024 at 12:01 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> Rewrite the comment above VMCS12_REVISION to unequivocally state that the
> ID must never change. KVM_{G,S}ET_NESTED_STATE have been officially
> supported for some time now, i.e. changing VMCS12_REVISION would break
> userspace.
>
> Opportunistically add a blurb to the CHECK_OFFSET() comment to make it
> explicitly clear that new fields are allowed, i.e. that the restriction
> on the layout is all about backwards compatibility.
>
> No functional change intended.
>
> Cc: Jim Mattson <jmattson@xxxxxxxxxx>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>