Re: [PATCH v2 2/3] spi: dt-bindings: fsl-dspi: Convert to yaml format

From: Rob Herring
Date: Thu Jun 13 2024 - 16:18:23 EST


On Thu, Jun 13, 2024 at 03:00:38PM -0400, Frank Li wrote:
> Convert dt-binding spi-fsl-dspi.txt to yaml format.
>
> Addtional changes during convert:
> - compatible string "fsl,ls1028a-dspi" can be followed by
> fsl,ls1021a-v1.0-dspi.
> - Change "dspi0@4002c000" to "spi@4002c000" in example.
> - Reorder properties in example.
> - Use GIC include in example.
> - Remove fsl,spi-cs-sck-delay and fsl,spi-sck-cs-delay by use common SPI
> property.

You can't just remove them. These are mature platforms using them and
replacing the properties would break kernels without your driver change.
The only compatible change would be put both properties in the DT.

You need to pick up what Vladimir did:

https://lore.kernel.org/linux-spi/20221111224651.577729-1-vladimir.oltean@xxxxxxx/

> - Use compatible string 'jedec,spi-nor' in example.
>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> .../devicetree/bindings/spi/fsl,dspi.yaml | 115 +++++++++++++++++++++
> .../devicetree/bindings/spi/spi-fsl-dspi.txt | 65 ------------
> 2 files changed, 115 insertions(+), 65 deletions(-)