Re: [net-next v5 2/2] net/mlx5e: Add per queue netdev-genl stats

[Jakub Kicinski]

On Thu, 13 Jun 2024 23:25:12 +0300 Tariq Toukan wrote:
> > +		for (i = priv->channels.params.num_channels; i < priv->stats_nch; i++) {  
> 
> IIUC, per the current kernel implementation, the lower parts won't be 
> completed in a loop over [0..real_num_rx_queues-1], as that loop is 
> conditional, happening only if the queues are active.

Could you rephrase this? Is priv->channels.params.num_channels
non-zero also when device is closed? I'm just guessing from 
the code, TBH, I can't parse your reply :(

> I would like the kernel to drop that condition, and stop forcing the 
> device driver to conditionally include this part in the base.
> 
> Otherwise, the lower parts need to be added here.

You'd need a stronger (and clearly explained) argument to change
the core. If you're saying that the kernel should be able to dump
queue stats for disabled queues - that seems rather questionable.