Re: [PATCH v3 5/5] nfsd: new netlink ops to get/set server pool_mode

[Jeff Layton]

On Thu, 2024-06-13 at 16:56 -0700, Jakub Kicinski wrote:
> On Thu, 13 Jun 2024 14:34:34 -0400 Jeff Layton wrote:
> > +	err = nla_put_string(skb, NFSD_A_POOL_MODE_MODE, buf) ||
> > +	      nla_put_u32(skb, NFSD_A_POOL_MODE_NPOOLS, nfsd_nrpools(net));
> 
> bitwise or?
> 

Yes. Good catch.

> Other option would be to move sunrpc_get_pool_mode() before allocation
> that way all error codes past allocations are EMSGSIZE and life is
> simpler.

Thanks, I'll probably do the latter.
-- 
Jeff Layton <jlayton@xxxxxxxxxx>