RE: [PATCH v2 00/25] Enable FRED with KVM VMX

[Li, Xin3]

> On Wed, Mar 27, 2024, Shan Kang wrote:
> > On Wed, 2024-02-07 at 09:26 -0800, Xin Li wrote:
> > > This patch set enables the Intel flexible return and event delivery
> > > (FRED) architecture with KVM VMX to allow guests to utilize FRED.
> > >
> > We tested this FRED KVM patch set on a 7th Intel(R) Core(TM) CPU and
> > the Intel Simics® Simulator with the following four configurations:
> 
> That likely provides coverage for the happy cases, but I doubt it provides negative
> testing, e.g. for VM-Enter consistency checks.  KVM-Unit-Tests are currently the
> best choice for concistency checks (unfortunately).
> 
> And given the insanity of event re-injection, KVM selftests needs a dedicated test
> for that, and another for the interactions with nVMX, e.g. a la
> svm_nested_soft_inject_test.c.
> 
> I haven't looked too closely at the selftest that's already provided, but my
> suspicion is that we'll want multiple tests, or alternatively one test that uses
> KVM_ONE_VCPU_TEST_SUITE().

What about posting the FRED selftests in another new patch set?

Thanks!
    Xin