Re: [PATCH net-next v13 05/13] net: ethtool: Allow passing a phy index for some commands

[Jakub Kicinski]

On Fri,  7 Jun 2024 09:18:18 +0200 Maxime Chevallier wrote:
> +		if (tb[ETHTOOL_A_HEADER_PHY_INDEX]) {
> +			struct nlattr *phy_id;
> +
> +			phy_id = tb[ETHTOOL_A_HEADER_PHY_INDEX];
> +			phydev = phy_link_topo_get_phy(dev,
> +						       nla_get_u32(phy_id));

Sorry for potentially repeating question (please put the answer in the
commit message) - are phys guaranteed not to disappear, even if the
netdev gets closed? this has no rtnl protection

> +			if (!phydev) {
> +				NL_SET_BAD_ATTR(extack, phy_id);
> +				return -ENODEV;
> +			}
> +		} else {
> +			/* If we need a PHY but no phy index is specified, fallback
> +			 * to dev->phydev

please double check the submission for going over 80 chars, this one
appears to be particularly pointlessly over 80 chars...

> +			 */
> +			phydev = dev->phydev;